Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vllm-openai upstream image #880

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Use vllm-openai upstream image #880

merged 1 commit into from
Feb 25, 2025

Conversation

ericcurtin
Copy link
Collaborator

@ericcurtin ericcurtin commented Feb 25, 2025 •
edited by sourcery-ai bot
Loading

The one we are currently using is old and doesn't have .gguf compatibility.

Summary by Sourcery

Enhancements:

  • Update the vLLM image to the upstream vllm-openai image, providing compatibility with the .gguf format.

@ericcurtin
Use vllm-openai upstream image
f237011 
The one we are currently using is old and doesn't have .gguf
compatibility.

Signed-off-by: Eric Curtin <ecurtin@redhat.com>
@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented Feb 25, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This PR updates the vLLM image used in the ramalama service to the upstream vllm-openai image. This change ensures compatibility with the .gguf format and uses a more up-to-date version of vLLM.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Update vLLM Docker image to the upstream vllm-openai image.
  • Replaced the custom quay.io/modh/vllm image with the official docker.io/vllm/vllm-openai image for vLLM runtime.
  • Removed conditional logic based on GPU type (HIP or CUDA) for selecting the vLLM image.
 ramalama/model.py
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Feb 25, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ericcurtin - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a comment explaining why the same image can be used for both CUDA and ROCm.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

engelmi
engelmi approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@engelmi engelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericcurtin ericcurtin merged commit 4b14026 into main Feb 25, 2025
17 checks passed
@ericcurtin ericcurtin deleted the vllm branch February 25, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@engelmi engelmi engelmi approved these changes

@rhatdan rhatdan Awaiting requested review from rhatdan rhatdan is a code owner

@bmahabirbu bmahabirbu Awaiting requested review from bmahabirbu bmahabirbu is a code owner

@maxamillion maxamillion Awaiting requested review from maxamillion maxamillion is a code owner

@swarajpande5 swarajpande5 Awaiting requested review from swarajpande5 swarajpande5 is a code owner

@jhjaggars jhjaggars Awaiting requested review from jhjaggars jhjaggars is a code owner

@cgruver cgruver Awaiting requested review from cgruver cgruver is a code owner

@slp slp Awaiting requested review from slp slp is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericcurtin @engelmi